Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2076#discussion_r16688959
--- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
@@ -68,7 +68,8 @@ private[spark] class CacheManager(blockManager:
BlockManager) extends Logging {
// Otherwise, cache the values and keep track of any updates in
block statuses
val updatedBlocks = new ArrayBuffer[(BlockId, BlockStatus)]
val cachedValues = putInBlockManager(key, computedValues,
storageLevel, updatedBlocks)
- context.taskMetrics.updatedBlocks = Some(updatedBlocks)
+ val metrics = context.taskMetrics
+ metrics.updatedBlocks =
Some(metrics.updatedBlocks.getOrElse(Seq[(BlockId, BlockStatus)]()) ++
updatedBlocks)
--- End diff --
Actually, why is this necessary? I believe the only place where you set
`metrics.updatedBlocks` is here, and for any given task this code path only
executes once. Can you explain your change here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
