Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15261#discussion_r80914401
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/feature/VectorIndexerSuite.scala ---
    @@ -121,10 +119,17 @@ class VectorIndexerSuite extends SparkFunSuite with 
MLlibTestSparkContext
     
         model.transform(densePoints1) // should work
         model.transform(sparsePoints1) // should work
    -    intercept[SparkException] {
    +    // If the data is local Dataset, it throws AssertionError directly.
    +    intercept[AssertionError] {
    --- End diff --
    
    Maybe off-topic for this review, but is this an assertion error? bad input 
shouldn't cause an assertion to trip.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to