Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r80957168
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -61,3 +61,12 @@ class JDBCOptions(
// TODO: to reuse the existing partition parameters for those partition
specific options
val createTableOptions = parameters.getOrElse("createTableOptions", "")
}
+
+object JDBCOptions {
+ // TODO: Theses property names are used in `JdbcUtils`,
`PostgresDialect` and `JDBCRDD`. It'd be
--- End diff --
If you plan to resolve this in a separate PR, how about remove all these
changes from this follow-up PR? These changes are not necessary, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
