Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/15249#discussion_r81018983
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -50,22 +48,12 @@ import org.apache.spark.util.{AccumulatorV2, Clock,
SystemClock, Utils}
* task set will be aborted
*/
private[spark] class TaskSetManager(
- sched: TaskSchedulerImpl,
+ val sched: TaskSchedulerImpl,
val taskSet: TaskSet,
val maxTaskFailures: Int,
- clock: Clock = new SystemClock())
- extends Schedulable with Logging {
+ val clock: Clock = new SystemClock()) extends Schedulable with Logging
{
--- End diff --
Why are `sched` and `clock` being made fields? It doesn't seem necessary
to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
