Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/15257#discussion_r81033312
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -60,6 +70,45 @@ object Literal {
}
/**
+ * Returns the Spark SQL DataType for a given class object. Since this
type needs to be resolved
+ * in runtime, we use match-case idioms for class objects here. However,
there are similar
+ * functions in other files (e.g., HiveInspectors), so these functions
need to merged into one.
+ */
+ private[this] def componentTypeToDataType(clz: Class[_]): DataType = clz
match {
+ // primitive types
+ case c: Class[_] if c == jShort.TYPE => ShortType
--- End diff --
the instance matching is not required here, it should be sufficient to use
`case jShort.TYPE`.
Btw, this is a nitpick but I would recommend that classes should start with
a capital letter, i.e. `java.lang.Short` could be imported as `JShort` rather
that `jShort`. In this case it really doesn't matter, but lower case classes
can bite you when your working with pattern matching
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
