Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15295#discussion_r81175674
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala 
---
    @@ -791,7 +791,7 @@ object SparkSession {
           // Get the session from current thread's active session.
           var session = activeThreadSession.get()
           if ((session ne null) && !session.sparkContext.isStopped) {
    -        options.foreach { case (k, v) => session.conf.set(k, v) }
    +        options.foreach { case (k, v) => 
session.sessionState.conf.setConfString(k, v) }
    --- End diff --
    
    yea, the goal is to forbid users to set/unset global sql conf via public 
API, but here we do need to set global sql conf with sparkConf, so we should 
use internal API here instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to