Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15288#discussion_r81191782
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
 ---
    @@ -1067,6 +1068,32 @@ class GeneralizedLinearRegressionSuite
           idx += 1
         }
       }
    +
    +  test("evaluate with labels that are not doubles") {
    +    // Evaulate with a dataset that contains Labels not as doubles to 
verify correct casting
    +    val datasetWithWeight = Seq(
    --- End diff --
    
    There's no need to have weights in this test, so it could be simplified a 
bit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to