Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/15285#discussion_r81199036
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/RollingFileAppender.scala ---
@@ -76,15 +79,40 @@ private[spark] class RollingFileAppender(
}
}
+ // Roll the log file and compress if enableCompression is true.
+ private def rotateFile(activeFile: File, rolloverFile: File): Unit = {
+ if (enableCompression) {
+ val gzFile = new File(rolloverFile.getAbsolutePath + GZIP_LOG_SUFFIX)
+ var gzOutputStream: GZIPOutputStream = null
+ var inputStream: InputStream = null
+ try {
+ inputStream = new FileInputStream(activeFile)
+ gzOutputStream = new GZIPOutputStream(new FileOutputStream(gzFile))
+ IOUtils.copy(inputStream, gzOutputStream)
+ activeFile.delete()
+ } finally {
+ IOUtils.closeQuietly(inputStream)
+ IOUtils.closeQuietly(gzOutputStream)
--- End diff --
What kinds of error do we expect? If there is an exception, we will lose
log data, right? Seems we should at least have a log.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
