Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/15301#discussion_r81270990
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala ---
@@ -102,6 +102,83 @@ abstract class Catalog {
def listColumns(dbName: String, tableName: String): Dataset[Column]
/**
+ * Find the database with the specified name. This returns [[None]] when
no [[Database]] can be
+ * found.
+ *
+ * @since 2.1.0
+ */
+ def findDatabase(dbName: String): Option[Database]
--- End diff --
Sorry, I'm a bit late to this party. In terms of Scala vs. Java API,
"find*" doesn't really strike me as the best naming, especially not after these
"find*" methods no longer produce an Option. In Scala, I expect a `find` to
take a predicate and to produce an Option that may contain the first element to
satisfy the predicate. Something that throws an exception when the one thing
asked for doesn't exist feels more like a `get` than a `find` to me.
Can we reconsider before we get to the point where we find that this API is
set in stone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
