Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r81330387
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ---
@@ -95,20 +95,20 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
*/
@throws[AnalysisException]("database does not exist")
override def listTables(dbName: String): Dataset[Table] = {
- requireDatabaseExists(dbName)
val tables = sessionCatalog.listTables(dbName).map { tableIdent =>
- makeTable(tableIdent, tableIdent.database.isEmpty)
+ makeTable(tableIdent)
}
CatalogImpl.makeDataset(tables, sparkSession)
}
- private def makeTable(tableIdent: TableIdentifier, isTemp: Boolean):
Table = {
- val metadata = if (isTemp) None else
Some(sessionCatalog.getTableMetadata(tableIdent))
+ private def makeTable(tableIdent: TableIdentifier): Table = {
--- End diff --
changes to this method is necessary, or `findTable` for global temp view
can't show database.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
