Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15249#discussion_r81422961
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetBlacklistSuite.scala ---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.scheduler
+
+import org.apache.spark.{SparkConf, SparkFunSuite}
+import org.apache.spark.internal.config
+import org.apache.spark.util.{ManualClock, SystemClock}
+
+class TaskSetBlacklistSuite extends SparkFunSuite {
+
+ test("Blacklisting individual tasks") {
+ val conf = new SparkConf().setAppName("test").setMaster("local")
+ .set(config.BLACKLIST_ENABLED.key, "true")
+ val clock = new ManualClock
+
+ val taskSetBlacklist = new TaskSetBlacklist(conf, stageId = 0, clock =
clock)
+ clock.setTime(0)
+ taskSetBlacklist.updateBlacklistForFailedTask("hostA", exec = "exec1",
index = 0)
+ for {
+ executor <- (1 to 4).map(_.toString)
+ index <- 0 until 10
+ } {
+ val exp = (executor == "exec1" && index == 0)
+ assert(taskSetBlacklist.isExecutorBlacklistedForTask(executor,
index) === exp)
+ }
+ assert(!taskSetBlacklist.isExecutorBlacklistedForTaskSet("exec1"))
+ assert(!taskSetBlacklist.isNodeBlacklistedForTaskSet("hostA"))
+
+ // Task 1 & 2 failed on both executor 1 & 2, so we should blacklist
all executors on that host,
+ // for all tasks for the stage. Note the api expects multiple checks
for each type of
+ // blacklist -- this actually fits naturally with its use in the
scheduler.
--- End diff --
Can you be more explicit here -- something like "Note the API will return
false for isExecutorBacklistedForTaskSet even when the node is blacklisted, so
the executor is implicitly blacklisted (this makes sense with how the scheduler
uses the blacklist)".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
