Github user mateiz commented on the pull request:

    https://github.com/apache/spark/pull/2091#issuecomment-53375345
  
    When you guys merge this, please close 
https://github.com/apache/spark/pull/122 as well. You should just edit the pull 
request description to also say "closes #122", and then it will close it when 
it merges. Let the person there know that this is now implemented as well, 
since that was a separate implementation. 
    
    BTW regarding evenBuckets -- I think it's more or less an accident that we 
exposed it in Scala, so I'd leave it out here. One awkward thing is that the 
Scala one is probably not even precise; it's not super clear that the 
floating-point math will work out such that each bucket's start / end is 
exactly the same result you get when doing the O(1) bucket computation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to