Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/15324
I tend to agree with Seth on this - the gaussian case is different enough
that it could be separate.
Though in terms of the estimator, from a public-facing API perspective it
is one param that is unused, so it it's not that big a deal to be unified.
However in terms of the model, I really, really don't like the hack of
putting the `theta` and `sigma` into one matrix. That leaves us with either
creating a new estimator/model combo (let's see how much code duplication that
involves), or having a `def getSigma` or a new val `sigma` that is only used
for Gaussian. Not super pretty...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
