Github user mattf commented on the pull request:
https://github.com/apache/spark/pull/2093#issuecomment-53415133
> @mattf While I was scanning down the whole file line by line in order to
find out all the issues related to persersesPartitioning, reformatting them in
the same time, if some lines did not looks nice to me. It's a completely
personal judgement, so maybe it does not make sense to others.
>
> It's not a good idea to do this kind of reformatting in in PR, I also was
thinking of do it as a separated PR or do not dot it if we have no necessary
reason.
>
> Should I remove these not-related changes?
if it were up to me, i'd say yes. it's not though, so i'll go with the flow.
i'm still trying to get a feel for what the spark community likes in its
PRs and JIRAs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
