Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/15249#discussion_r81859869
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/ExecutorFailuresInTaskSet.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.scheduler
+
+import scala.collection.mutable.HashMap
+
+/**
+ * Small helper for tracking failed tasks for blacklisting purposes. Info
on all failures for one
+ * task set, within one task set.
+ */
+class ExecutorFailuresInTaskSet(val node: String) {
+ /**
+ * Mapping from index of the tasks in the taskset, to the number of
times it has failed on this
+ * executor and the last time it failed.
+ */
+ val taskToFailureCountAndExpiryTime = HashMap[Int, (Int, Long)]()
+
+ def updateWithFailure(taskIndex: Int, failureExpiryTime: Long): Unit = {
+ val (prevFailureCount, prevFailureExpiryTime) =
+ taskToFailureCountAndExpiryTime.getOrElse(taskIndex, (0, -1L))
+ assert(failureExpiryTime >= prevFailureExpiryTime)
--- End diff --
nit: This assertion need not hold in face of clock skew, etc.
(I faced similar issues elsewhere, ymmv ofcourse !)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
