Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/15307#discussion_r81874295
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -105,11 +111,14 @@ class StreamExecution(
var lastExecution: QueryExecution = null
@volatile
- var streamDeathCause: StreamingQueryException = null
+ private var streamDeathCause: StreamingQueryException = null
/* Get the call site in the caller thread; will pass this into the micro
batch thread */
private val callSite = Utils.getCallSite()
+ private val streamMetrics = new StreamMetrics(uniqueSources.toSet,
triggerClock,
--- End diff --
nit: break at the highest semantic level to avoid breaking in the middle of
things that are the same. i.e.
```scala
private val streamMetrics =
new StreamMetrics(uniqueSources.toSet, triggerClock,
s"StructuredStreaming.$name")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
