Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15357#discussion_r81900460
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
    @@ -265,7 +265,9 @@ class SparkSqlAstBuilder(conf: SQLConf) extends 
AstBuilder {
         }
     
         val statement = plan(ctx.statement)
    -    if (isExplainableStatement(statement)) {
    +    if (statement == null) {
    +      null  // This is enough since ParseException will raise later.
    --- End diff --
    
    Where will the parseException be raised? Could you be a bit more specific 
in your comment?
    
    Maybe add a small test for this? Could you also add a few unit tests (not 
end-2-end) to SparkSqlParserSuite.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to