Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15347#discussion_r82042420
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -145,7 +145,9 @@ private UnsafeExternalSorter(
// Use getSizeAsKb (not bytes) to maintain backwards compatibility for
units
// this.fileBufferSizeBytes = (int)
conf.getSizeAsKb("spark.shuffle.file.buffer", "32k") * 1024;
this.fileBufferSizeBytes = 32 * 1024;
- this.writeMetrics = taskContext.taskMetrics().shuffleWriteMetrics();
+ // The spill metrics are stored in a new ShuffleWriteMetrics, and then
discarded (this fixes SPARK-16827).
+ // TODO: Instead, separate spill metrics should be stored and reported
(tracked in SPARK-3577).
+ this.writeMetrics = new ShuffleWriteMetrics();
--- End diff --
so this isn't actually used anywhere right now? Is that what the TODO is
about?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
