Github user sethah commented on the issue: https://github.com/apache/spark/pull/11119 One minor comment, otherwise LGTM. We should still consider overriding equals method as a follow up item. Also, we should discuss changing the behavior so that if initial model is set, then we simply use the implied value of `k`. e.g. we can train using this: ````scala val kmeansModel = new KMeans().setInitialModel(model).fit(df) ```` I created [SPARK-17789](https://issues.apache.org/jira/browse/SPARK-17789) for this.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org