Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r81988012
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -1189,6 +1217,10 @@ private[spark] class Client(
private object Client extends Logging {
def main(argStrings: Array[String]) {
+ mainWithEnv(argStrings, Map() ++ sys.env)
+ }
+
+ def mainWithEnv(argStrings: Array[String], env: Map[String, String]):
Unit = {
if (!sys.props.contains("SPARK_SUBMIT")) {
--- End diff --
this needs to check env in addition to sys.props since you are adding the
sys props to the env? Really Client is now private so I don't see a reason to
have this at all, we should just remove the warning as well as the setting of
SPARK_SUBMIT in SparkSubmit.scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
