Github user frreiss commented on a diff in the pull request:
https://github.com/apache/spark/pull/15352#discussion_r82085912
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -207,13 +207,18 @@ class StreamExecution(
})
} catch {
case _: InterruptedException if state == TERMINATED => //
interrupted by stop()
- case NonFatal(e) =>
+ case e: Throwable =>
streamDeathCause = new StreamingQueryException(
this,
s"Query $name terminated with exception: ${e.getMessage}",
e,
Some(committedOffsets.toCompositeOffset(sources)))
logError(s"Query $name terminated with error", e)
+ // Rethrow the fatal errors to allow the user using
`Thread.UncaughtExceptionHandler` to
+ // handle them
+ if (!NonFatal(e)) {
+ throw e
--- End diff --
`StreamExecution.stop()` won't have been called if the microbatch thread
arrives at this location in the code, and the user likely won't call it after
seeing the exception. You should probably call the `stop` method on each of the
sources before exiting the microbatch thread here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
