Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15314#discussion_r82086987
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -106,6 +106,13 @@ private[regression] trait
GeneralizedLinearRegressionBase extends PredictorParam
schema: StructType,
fitting: Boolean,
featuresDataType: DataType): StructType = {
+ if (fitting) {
+ if (isDefined(weightCol) && $(weightCol).nonEmpty) {
+ SchemaUtils.checkNumericType(schema, $(weightCol))
+ } else {
+ logInfo("The weight column is not defined. Treat all instance
weights as 1.0.")
--- End diff --
Do we need these log messages? The behavior with weight column is clearly
defined in the docs. I vote to exclude them. If we end up not logging a message
here, we can remove the inheritance from logging. In fact for
GeneralizedLinearRegression, these params already inherited from Logging but
did not need to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
