Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15366#discussion_r82130871
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -462,7 +462,10 @@ private[ui] class JobDataSource(
}
case "Description" => new Ordering[JobTableRowData] {
override def compare(x: JobTableRowData, y: JobTableRowData): Int =
- Ordering.String.compare(x.lastStageDescription,
y.lastStageDescription)
+ (x.lastStageDescription, y.lastStageDescription) match {
--- End diff --
You know, this and all the other Orderings here could be simpler. This one
can be
`case "Description" => Ordering.by(x => (x.lastStageName,
x.lastStageDescription))`
Others like the one above should be `Ordering.by(_.jobData.jobId)`. If
that's right I think it may be useful to simplify this pattern everywhere while
here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
