Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15371#discussion_r82132969
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -312,11 +312,15 @@ private[spark] object JsonProtocol {
// We only have 3 kind of internal accumulator types, so if it's
not int or long, it must be
// the blocks accumulator, whose type is `java.util.List[(BlockId,
BlockStatus)]`
case v =>
- JArray(v.asInstanceOf[java.util.List[(BlockId,
BlockStatus)]].asScala.toList.map {
- case (id, status) =>
- ("Block ID" -> id.toString) ~
- ("Status" -> blockStatusToJson(status))
- })
+ val blockAccumulator =
--- End diff --
I don't see why this would help. You add a wrapper, but, synchronizing your
local access to it doesn't do anything because nothing else is synchronizing on
it.
PS can the `List[(BlockId,BlockStatus)]` type just be part of the match
predicate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
