Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2019#discussion_r16731768
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -280,42 +280,46 @@ private[spark] class ConnectionManager(
}
while(!keyInterestChangeRequests.isEmpty) {
+ // Expect key interested in OP_ACCEPT is not change its interest
val (key, ops) = keyInterestChangeRequests.dequeue()
-
try {
- if (key.isValid) {
+ key.synchronized {
--- End diff --
Why do you say they are fatal? They're just normal things. Nothing is
broken when those exceptions happen, because the code is handling them. The
only thing that happens is that ugly messages are printed to the logs.
As Mridul mentioned, I think it's better to handle these situations than to
avoid them, because it's pretty tricky to avoid them. The code already seems to
handle these exceptions properly, and your solution to avoiding them
altogether may have performance side-effects.
So unless something is actually broken (which I don't think it is), why try
to avoid the exceptions in the first place?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
