Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13868#discussion_r82252372
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -55,7 +56,7 @@ object SQLConf {
       val WAREHOUSE_PATH = SQLConfigBuilder("spark.sql.warehouse.dir")
         .doc("The default location for managed databases and tables.")
         .stringConf
    -    .createWithDefault("file:${system:user.dir}/spark-warehouse")
    +    .createWithDefault("${system:user.dir}/spark-warehouse")
    --- End diff --
    
    Yes that would resolve it, probably, if the intent is to let this become a 
directory on HDFS. I think it was supposed to be a local file so maybe we have 
to find a Windows-friendly way to bring back the `file:` prefix.
    
    Maybe make the default value just "spark-warehouse" and then below in `def 
warehousePath`, add logic to resolve this explicitly against the 
`LocalFilesystem`? I'll give that a shot soon if nobody has better ideas.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to