Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15360#discussion_r82279052
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
    @@ -405,6 +405,78 @@ class StatisticsSuite extends QueryTest with 
TestHiveSingleton with SQLTestUtils
         }
       }
     
    +  test("check column statistics for case sensitive columns") {
    +    val tableName = "tbl"
    +    // scalastyle:off
    +    // non ascii characters are not allowed in the source code, so we 
disable the scalastyle.
    +    val columnGroups: Seq[(String, String)] = Seq(("c1", "C1"), ("列c", 
"列C"))
    +    // scalastyle:on
    +    columnGroups.foreach { case (column1, column2) =>
    --- End diff --
    
    Could you create a separate function for the following checking logics? 
Then, you can have two test cases without duplicate codes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to