Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15381#discussion_r82339491
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java
---
@@ -90,8 +95,21 @@ public void run() {
Arrays.toString(sslContextFactory.getExcludeProtocols()));
sslContextFactory.setKeyStorePath(keyStorePath);
sslContextFactory.setKeyStorePassword(keyStorePassword);
- connector = new ServerConnector(httpServer, sslContextFactory);
+ connectionFactories = AbstractConnectionFactory.getFactories(
--- End diff --
I don't think so just because I copied it from the Jetty constructor that
was already being called in this path:
```
/* ------------------------------------------------------------ */
/** HTTP Server Connection.
* <p>Construct a ServerConnector with a private instance of {@link
HttpConnectionFactory} as the primary protocol</p>.
* @param server The {@link Server} this connector will accept
connection for.
* @param sslContextFactory If non null, then a {@link
SslConnectionFactory} is instantiated and prepended to the
* list of HTTP Connection Factory.
*/
public ServerConnector(
@Name("server") Server server,
@Name("sslContextFactory") SslContextFactory sslContextFactory)
{
this(server,null,null,null,-1,-1,AbstractConnectionFactory.getFactories(sslContextFactory,new
HttpConnectionFactory()));
}
```
However if this wasn't actually the intended behavior we can change it of
course.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
