Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15366#discussion_r82367835
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
    @@ -462,7 +462,10 @@ private[ui] class JobDataSource(
           }
           case "Description" => new Ordering[JobTableRowData] {
             override def compare(x: JobTableRowData, y: JobTableRowData): Int =
    -          Ordering.String.compare(x.lastStageDescription, 
y.lastStageDescription)
    +          (x.lastStageDescription, y.lastStageDescription) match {
    --- End diff --
    
    Personally, I think it's worth improving this everywhere for consistency. 
It's not random in that you did have to update one of a series of pieces of 
code, and wanted to do it cleanly, and then it becomes valuable to make it 
consistent. If you're up for it, please do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to