Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15370#discussion_r82386685
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -71,6 +72,11 @@ private[spark] object CallSite {
     private[spark] object Utils extends Logging {
       val random = new Random()
     
    +  // Use a common file numbering format which defaults to 5 digits for 
saving various part files.
    +  val numFormatter = NumberFormat.getIntegerInstance()
    --- End diff --
    
    
    If this is used by multiple different classes for formatting the number if 
seems fine to be in Utils. How about instead we have a function in here that is 
formatPartitionNumber(int id) which internally uses the number formatter?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to