GitHub user davies opened a pull request:

    https://github.com/apache/spark/pull/15390

    [SPARK-17806] [SQL] fix bug in join key rewritten in HashJoin

    ## What changes were proposed in this pull request?
    
    In HashJoin, we try to rewrite the join key as Long to improve the 
performance of finding a match. The rewriting part is not well tested, has a 
bug that could cause wrong result when there are at least three integral 
columns in the joining key also the total length of the key exceed 8 bytes. 
    
    ## How was this patch tested?
    
    Added unit test to covering the rewriting with different number of columns 
and different data types. Manually test the reported case and confirmed that 
this PR fix the bug.
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davies/spark rewrite_key

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15390.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15390
    
----
commit 974fadb748488c1375d8ba93b6b4b3290b0e02e2
Author: Davies Liu <[email protected]>
Date:   2016-10-07T17:20:07Z

    fix join key rewritten

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to