Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15074#discussion_r82454768
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -1296,9 +1296,19 @@ def asML(self):
return newlinalg.SparseMatrix(self.numRows, self.numCols,
self.colPtrs, self.rowIndices,
self.values, self.isTransposed)
- # TODO: More efficient implementation:
def __eq__(self, other):
- return np.all(self.toArray() == other.toArray())
+ if ((type(other) is not type(self)) or
--- End diff --
So this will return false for a spare matrix and a dense matrix being equal
to eachother even if all of the elements are equal, and previously this was not
the case. This also doesn't match the Scala implementation. Ping @dbtsai who
has been doing some of the mllib-local/linalg stuff :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
