Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/14394#discussion_r82463086
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala ---
@@ -777,6 +777,10 @@ class DistributedLDAModel private[clustering] (
JavaPairRDD.fromRDD(topicDistributions.asInstanceOf[RDD[(java.lang.Long,
Vector)]])
}
+ override def topicDistributions(documents: RDD[(Long, Vector)]):
RDD[(Long, Vector)] = {
--- End diff --
Is this what we want here? It seems having it defined on the parent if half
of the children aren't implementing it might be confusing to some users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
