Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2139#discussion_r16739165
--- Diff: dev/create-release/generate-changelist.py ---
@@ -125,7 +125,7 @@ def cleanup(ask=True):
pr_num = [line.split()[1].lstrip("#") for line in body_lines
if "Closes #" in line][0]
github_url = "github.com/apache/spark/pull/%s" % pr_num
day = time.strptime(date.split()[0], "%Y-%m-%d")
- if day < SPARK_REPO_CHANGE_DATE1 or
+ if day < SPARK_REPO_CHANGE_DATE1 or \
--- End diff --
I generally prefer to use parentheses for this:
if (really long condition that
spans more than one line):
But this is fine too. Since you're here, can you fix the indentation on the
next line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
