Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/13036#discussion_r82480308
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -470,7 +470,7 @@ def sampleBy(self, col, fractions, seed=None):
+---+-----+
"""
- if not isinstance(col, str):
+ if not isinstance(col, basestring):
--- End diff --
Is there some harm in allowing unicode here though? If my column is `'a'`
and I call `sampleBy(u'a')` it will work after this change, otherwise it will
throw an error. I think it's better to treat `'a'` and `u'a'` as equivalent...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
