Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15389#discussion_r82493650
  
    --- Diff: python/pyspark/rdd.py ---
    @@ -2029,7 +2030,11 @@ def coalesce(self, numPartitions, shuffle=False):
             >>> sc.parallelize([1, 2, 3, 4, 5], 3).coalesce(1).glom().collect()
             [[1, 2, 3, 4, 5]]
             """
    -        jrdd = self._jrdd.coalesce(numPartitions, shuffle)
    +        if shuffle:
    +            data_java_rdd = 
self._to_java_object_rdd().coalesce(numPartitions, shuffle)
    +            jrdd = self.ctx._jvm.SerDeUtil.javaToPython(data_java_rdd)
    --- End diff --
    
    Yah that seems close enough we don't need to worry (and for the big cases 
presumably the impact of having better balanced partitions is well worth the 
slight overhead).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to