Github user seyfe commented on a diff in the pull request:
https://github.com/apache/spark/pull/15371#discussion_r82528765
--- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala ---
@@ -444,7 +444,7 @@ class CollectionAccumulator[T] extends AccumulatorV2[T,
java.util.List[T]] {
override def copy(): CollectionAccumulator[T] = {
val newAcc = new CollectionAccumulator[T]
- newAcc._list.addAll(_list)
+ newAcc.merge(this)
--- End diff --
I don't have a strong opinion so let me change `merge()` with
`synchronized` block as you suggested.
I also propose changing `BlockStatusesAccumulator` to use `setValue()`
rather than `merge()` to avoid extra type matching.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
