Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15388#discussion_r82536075
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSetSuite.scala
---
@@ -80,6 +80,59 @@ class ExpressionSetSuite extends SparkFunSuite {
setTest(1, Not(aUpper >= 1), aUpper < 1, Not(Literal(1) <= aUpper),
Literal(1) > aUpper)
setTest(1, Not(aUpper <= 1), aUpper > 1, Not(Literal(1) >= aUpper),
Literal(1) < aUpper)
+ setTest(1, aUpper > bUpper && aUpper <= 10, aUpper <= 10 && aUpper >
bUpper)
+ setTest(1,
+ aUpper > bUpper && bUpper > 100 && aUpper <= 10,
+ bUpper > 100 && aUpper <= 10 && aUpper > bUpper)
+
+ setTest(1, aUpper > bUpper || aUpper <= 10, aUpper <= 10 || aUpper >
bUpper)
+ setTest(1,
+ aUpper > bUpper || bUpper > 100 || aUpper <= 10,
+ bUpper > 100 || aUpper <= 10 || aUpper > bUpper)
+
+ setTest(1,
+ bUpper > 100 || aUpper <= 10 && aUpper > bUpper,
+ bUpper > 100 || (aUpper <= 10 && aUpper > bUpper))
+
+ setTest(1,
+ aUpper > 10 && bUpper < 10 || aUpper >= bUpper,
+ (bUpper < 10 && aUpper > 10) || aUpper >= bUpper)
+
+ setTest(1,
--- End diff --
For these few test cases, they are getting too complicated that a human
won't be able to tell immediately what the case is testing for. We should add
some comment explaining what is being tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
