Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15358#discussion_r82655758
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
 ---
    @@ -52,9 +52,15 @@ case class CatalogStorageFormat(
         properties: Map[String, String]) {
     
       override def toString: String = {
    +    val maskedProperties = properties.map {
    +      case (password, _) if password.toLowerCase == "password" => 
(password, "###")
    --- End diff --
    
    In Oracle, the specification of `password` and `user` in `url` does not 
follow the same pattern we expect. Below is an example:
    ```
    jdbc:oracle:thin:scott/tiger@localhost:1521:orcl
    ```
    The reference link: 
http://docs.oracle.com/cd/B28359_01/java.111/b31224/urls.htm
    
    So far, the dialect does not help. Let me know whether we should add more 
code changes for utilizing dialects. Thanks! @rxin 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to