Github user seyfe commented on a diff in the pull request:
https://github.com/apache/spark/pull/15371#discussion_r82679357
--- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala ---
@@ -444,7 +444,9 @@ class CollectionAccumulator[T] extends AccumulatorV2[T,
java.util.List[T]] {
override def copy(): CollectionAccumulator[T] = {
val newAcc = new CollectionAccumulator[T]
- newAcc._list.addAll(_list)
+ _list.synchronized {
--- End diff --
@mridulm , I don't think that your statement is correct.
`SynchronizedCollection` is protected by
` final Object mutex; // Object on which to synchronize
`
If you look at the constructor you will see that
` mutex = this;
`
Does that make sense now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
