Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2065#discussion_r16754092
  
    --- Diff: external/flume-sink/pom.xml ---
    @@ -71,6 +71,10 @@
           <scope>test</scope>
         </dependency>
         <dependency>
    +      <groupId>org.scala-lang</groupId>
    --- End diff --
    
    The thing is this project does not depend on spark-core, its standalone. So 
it actually makes sense to add scala-library directly. However, the current 
code surprisingly compiles (both sbt and maven) even if we dont have 
scala-library as the dependency. Probably because scala compiler automatically 
brings in scala. 
    
    I am of the opinion that we should add this back in, but ensure that this 
has the same version of scala as the spark core. Can you take a look at this, 
@srowen . 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to