Github user MLnick commented on a diff in the pull request:
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
    @@ -300,15 +301,23 @@ private[ml] object DefaultParamsWriter {
           paramMap: Option[JValue] = None): String = {
         val uid = instance.uid
         val cls = instance.getClass.getName
    -    val params = 
    +    val params = instance.extractParamMap().toSeq
    +      .filter( != 
    --- End diff --
    Is it not possible to check if the param is an instance of 
`Param[Model[_]]` rather than the name?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to