Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/15307#discussion_r82872469
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -176,7 +184,9 @@ class StreamExecution(
// Mark ACTIVE and then post the event. QueryStarted event is
synchronously sent to listeners,
// so must mark this as ACTIVE first.
state = ACTIVE
- postEvent(new QueryStarted(this.toInfo)) // Assumption: Does not
throw exception.
+
sparkSession.sparkContext.env.metricsSystem.registerSource(streamMetrics)
+ updateStatus()
+ postEvent(new QueryStarted(currentStatus)) // Assumption: Does not
throw exception.
--- End diff --
it's good to be consistent. Otherwise if you want to change the behavior of
status for example, then this line will not be left orphaned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
