GitHub user mpjlu opened a pull request: https://github.com/apache/spark/pull/15444
[SPARK-17870][MLLIB][ML]Change statistic to pValue for SelectKBest and SelectPercentile because of DoF difference ## What changes were proposed in this pull request? For feature selection method ChiSquareSelector, it is based on the ChiSquareTestResult.statistic (ChiSqure value) to select the features. It select the features with the largest ChiSqure value. But the Degree of Freedom (df) of ChiSqure value is different in Statistics.chiSqTest(RDD), and for different df, you cannot base on ChiSqure value to select features. So we change statistic to pValue for SelectKBest and SelectPercentile ## How was this patch tested? change existing test You can merge this pull request into a Git repository by running: $ git pull https://github.com/mpjlu/spark chisqure-bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/15444.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15444 ---- commit 59ee17df3b46996bcf62f427c21d0f89b6ced204 Author: Peng <peng.m...@intel.com> Date: 2016-10-12T01:10:39Z Change statistic to pValue for SelectKBest and SelectPercentile ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org