Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15434#discussion_r82938529
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -459,11 +459,20 @@ class SessionCatalog(
* If a database is specified in `oldName`, this will rename the table
in that database.
* If no database is specified, this will first attempt to rename a
temporary table with
* the same name, then, if that does not exist, rename the table in the
current database.
+ *
+ * This assumes the database specified in `newName` matches the one in
`oldName`.
*/
- def renameTable(oldName: TableIdentifier, newName: String): Unit =
synchronized {
+ def renameTable(oldName: TableIdentifier, newName: TableIdentifier):
Unit = synchronized {
val db = formatDatabaseName(oldName.database.getOrElse(currentDb))
+ newName.database.map(formatDatabaseName).foreach { newDb =>
--- End diff --
see PR description, we should use the database of source table, so that
users can just write `db.tbl1 RENAME TO tbl2`. This is different from Hive, as
we don't support move table from one database to another.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
