Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15433#discussion_r82960799
--- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala
---
@@ -284,7 +286,7 @@ private[r] object JVMObjectTracker {
objId
}
- def remove(id: String): Option[Object] = {
+ def remove(id: String) {
--- End diff --
Although it's normal to return the object that was removed from map
methods, if this isn't desired, I'd declare this as `: Unit` to be clear
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
