Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/15411
  
    I think it's right to do this all at once, rather than in pieces.
    
    I must say I recall I opened a PR like this a long long time ago and Matei 
said the master was excluded on purpose because it was intended to be set by 
the environment running the example, which made some sense.
    
    I wonder if the logic is still the same or not? that is, if it's a runnable 
example, do we want to not override the master that the runner might set? or 
for doc-only example code, is it that we do need to show master being set 
programmatically?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to