Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15230#discussion_r83006784
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -225,6 +225,11 @@ case class AlterTableSetPropertiesCommand(
         val catalog = sparkSession.sessionState.catalog
         val table = catalog.getTableMetadata(tableName)
         DDLUtils.verifyAlterTableType(catalog, table, isView)
    +    // Not allowed to switch the table type.
    +    if (properties.contains("EXTERNAL")) {
    --- End diff --
    
    In the initial fix, it is only for Hive. : )
    
    Moving it to `verifyTableProperties` sounds good to me. It also covers 
another case. Users are unable to set `EXTERNAL` in `CREATE TABLE`. Let me do 
it. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to