Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/15432
  
    Not sure whether you realize it. Since this PR changes the input parm of 
`Rand` and `Randn`, you also changes the external support. 
    
    Now, users can do something like
    ```SQL
    select rand(cast(9 / 4 as int)) from src
    ```
    
    My suggestion is to always add new test cases whenever you made an external 
change like this. It can help reviewers decide whether this PR is good or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to