Github user zsxwing commented on the issue:
    > I also missed why close() shouldn't be synchronized. You wouldn't want it 
to take place during a read, right?
    Good point. I was thinking `FileChannel.close` is safe but didn't consider 
this case.
    > I think a finalizer wouldn't hurt here because FileInputStream does it. 
It's exactly because people may not properly close the stream.
    Agreed that it doesn't hurt the performance since FileInputStream does it.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to